Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

From: Guenter Roeck
Date: Wed Sep 13 2017 - 10:13:05 EST


On Wed, Sep 13, 2017 at 07:36:16AM +0200, Florian Eckert wrote:
> Hello Rob
>
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> >>> @@ -0,0 +1,10 @@
> >>> +Lantiq cpu temperatur sensor
> >
> >s/temperatur/temperature/
>
> Will update this in a follow up page based on the old one. So no v4?
>
Please send a follow-up patch.

Thanks,
Guenter

> >
> >>> +
> >>> +Requires node properties:
> >>> +- compatible value :
> >>> + "lantiq,cputemp"
> >
> >Kind of non-specific. How is this device even accessed without any other
> >property?
>
> It does not need any further properties. If this is set in the device tree
> then the driver is loaded.
> After loading the temperature could be read from "/sys/class/hwmon".
>
> Let me know what should i do to get this fixed?
>
> Thanks for feedback
>
> Florian
>