Re: [Outreachy kernel] [PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t

From: Julia Lawall
Date: Sat Sep 16 2017 - 13:20:24 EST




On Sat, 16 Sep 2017, Srishti Sharma wrote:

> Eliminate the fields that are not used and the comments
> associated with them.
>
> Signed-off-by: Srishti Sharma <srishtishar@xxxxxxxxx>

Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_driver.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 5d2566e..082d659 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -312,8 +312,6 @@ struct un_t {
> * @ch_err_overrun: Count of overruns on channel.
> * @ch_xon_sends: Count of xons transmitted.
> * @ch_xoff_sends: Count of xoffs transmitted.
> - * @proc_entry_pointer: Proc/<board>/<channel> entry.
> - * @dgnc_channel_table: Proc/<board>/<channel> entry.
> */
> struct channel_t {
> struct dgnc_board *ch_bd;
> @@ -382,10 +380,6 @@ struct channel_t {
>
> ulong ch_xon_sends;
> ulong ch_xoff_sends;
> -
> - struct proc_dir_entry *proc_entry_pointer;
> - struct dgnc_proc_entry *dgnc_channel_table;
> -
> };
>
> extern uint dgnc_major; /* Our driver/mgmt major */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>