Re: [PATCH] scripts/dtc: update dtx_diff cpp and dts include paths to match build
From: Frank Rowand
Date: Sat Sep 16 2017 - 13:53:18 EST
On 09/15/17 15:42, Rob Herring wrote:
> On Fri, Sep 15, 2017 at 5:16 PM, <frowand.list@xxxxxxxxx> wrote:
>> From: Frank Rowand <frank.rowand@xxxxxxxx>
> I feel like we just had the same subject. Can you make it more specific.
Yes, the previous one was pretty much the same words, but the one line
description is not an exact match. I will come up with a more unique
>> Update dtx_diff include paths in the same manner as:
>> commit b12869a8d519 ("of: remove drivers/of/testcase-data from
>> include search path for CPP"), commit 5ffa2aed389c ("of: remove
>> arch/$(SRCARCH)/boot/dts from include search path for CPP"), and
>> commit 50f9ddaf64e1 ("of: search scripts/dtc/include-prefixes path
>> for both CPP and DTC").
> We need a better way for this to stop happening besides me remembering
> in reviews...
Yep, me remembering in reviews. Which I have. :-)
> Perhaps a separate file of include paths that all tools can use?
I considered that with the very first version of dtx_diff. At the time,
I expected changes to the include path to be very rare. I still have
that expectation looking forward.
I considered having dtx_diff scrape the include paths out of Makefile.lib,
but that seemed fragile and kludgey. I could create a shell script that
outputs the include paths, Then Makefile.lib and dtx_diff could use
that script to get the include paths.
>> Remove proposed include path kernel/dts/, which was never implemented
>> for the dtb build.
>> For the diff case, each source file is compiled separately. For
>> each of those compiles, provide the location of the source file
>> as an include path, not the location of both source files.
>> The referenced commits b12869a8d519, 5ffa2aed389c, 50f9ddaf64e1
>> are in v4.14-rc1. No stable kernels need this patch.
>> scripts/dtc/dtx_diff | 22 +++++++++-------------
>> 1 file changed, 9 insertions(+), 13 deletions(-)
>> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> This is going to get dropped.
I am assuming the drop is because of the request to have a common
file for all tools to source for the include paths. I'll re-spin
to implement that.