Re: [PATCH V2] tipc: Use bsearch library function

From: Thomas Meyer
Date: Sun Sep 17 2017 - 11:00:26 EST

> Am 16.09.2017 um 15:20 schrieb Jon Maloy <jon.maloy@xxxxxxxxxxxx>.
>> What part of "very time critical" have you verified and benchmarked as
>> inconsequential?
>> Please post your results.
> I agree with Joe here. This change does not simplify anything, it does not reduce the amount of code, plus that it introduce an unnecessary outline call in a place where we have every reason to let the compiler do its optimization job properly.


Okay, should I prepare some performance numbers or do we NAK this change?
What about the other binary search implementation in the same file? Should I try to convert it it will it get NAKed for performance reasons too?

With kind regards

Attachment: smime.p7s
Description: S/MIME cryptographic signature