Re: [PATCH] Revert "KVM: Don't accept obviously wrong gsi values via KVM_IRQFD"

From: Michael Ellerman
Date: Mon Sep 18 2017 - 02:44:41 EST


"Jan H. SchÃnherr" <jschoenh@xxxxxxxxx> writes:

> This reverts commit 36ae3c0a36b7456432fedce38ae2f7bd3e01a563.
>
> The commit broke compilation on !CONFIG_HAVE_KVM_IRQ_ROUTING. Also,
> there may be cases with CONFIG_HAVE_KVM_IRQ_ROUTING, where larger
> gsi values make sense.
>
> As the commit was meant as an early indicator to user space that
> something is wrong, reverting just restores the previous behavior
> where overly large values are ignored when encountered (without
> any direct feedback).
>
> Reported-by: Abdul Haleem <abdhalee@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jan H. SchÃnherr <jschoenh@xxxxxxxxx>
> ---
> virt/kvm/eventfd.c | 2 --
> 1 file changed, 2 deletions(-)

Can someone merge this or preferably just send it straight to Linus, the
original patch has broken the powerpc build in mainline.

cheers