Re: [PATCH] perf, tools: Fix adding multiple event groups

From: Jiri Olsa
Date: Mon Sep 18 2017 - 02:58:56 EST


On Thu, Sep 14, 2017 at 01:57:35PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> The -M metric group parser threw away the events of earlier
> groups when multiple groups were specified. Fix this here
> by not overwriting the string incorrectly.
>
> Now this works correctly:
>
> % perf stat -M Summary,SMT --metric-only -a sleep 1
>
> Performance counter stats for 'system wide':
>
> Instructions CPI CLKS CPU_Utilization GFLOPs SMT_2T_Utilization SMT_2T_Utilization Kernel_Utilization CoreIPC CORE_CLKS
> 900907376.0 2.7 2398954144.0 0.1 0.0 0.2 0.2 0.1 0.4 2080822855.5
>
> while previously it would only show the SMT metrics.
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka