Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor

From: Maxime Ripard
Date: Mon Sep 18 2017 - 04:24:19 EST

On Sat, Sep 16, 2017 at 06:14:08PM +0800, icenowy@xxxxxxx wrote:
> > The H3 apparently supports IRQs, why do you not support them for the
> > temperature? They might be broken as it is on A33 but then it might be a
> > good idea to write it down in a comment in the driver (and not adding
> > the unused registers in the header file) or at least in the commit log.
> >
> > 3) Now that you have support for clocks, wouldn't it be a good idea to
> > disable them during suspend?
> Interesting... It's meaningful to disable the mod clock during suspend.

All clocks, actually. And put the device back into reset.


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering

Attachment: signature.asc
Description: PGP signature