Re: [PATCH] Staging: media: atomisp: Merge assignment with return

From: Sakari Ailus
Date: Mon Sep 18 2017 - 07:44:36 EST


On Tue, Sep 12, 2017 at 07:55:07PM +0530, Srishti Sharma wrote:
> Merge the assignment and the return statements to return the value
> directly. Done using the following semantic patch by coccinelle.
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Srishti Sharma <srishtishar@xxxxxxxxx>

Hi Srishti,

I've merged the two patches as they're trivial and the commit message is
the same.

It's entirely reasonable to have a patch per driver but you should mention
that in the commit message (subject line) at least. This case is a bit
special because the other driver is also specific to the atomisp staging
driver.

Thanks.

--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx