Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

From: Philipp Zabel
Date: Mon Sep 18 2017 - 08:07:30 EST


On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote:
> ARC AXS10x boards support custom IP-block which allows to control
> reset signals of selected peripherals. For example DW GMAC, etc...
> This block is controlled via memory-mapped register (AKA CREG) which
> represents up-to 32 reset lines. This regiter is self-clearing so we
> don't need to deassert line after reset.
>
> As of today only the following lines are used:
> Â- DW GMAC - line 5
>
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>
> ---
> Changes v1 -> v2:
> Â * The creg reset register is self-clearing so we don't need to clear it
> ÂÂÂÂmanually. Fixed it.
> Â * Use reset callback instead of assert/deassert pair.
> Â * Rename reset node in documentation to "reset-controller" for consistency
> ÂÂÂÂwith the other bindings.
> Â * Use devm_reset_controller_register instead of reset_controller_register
>
> NOTE:
> ÂÂÂÂThis driver couldn't be replaced by reset-simple driver as we mustn't
> ÂÂÂÂread from reset register or clear it.

Thanks, I've applied this patch to the reset/next branch.

regards
Philipp