Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c

From: Greg Kroah-Hartman
Date: Mon Sep 18 2017 - 10:09:30 EST


On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:
> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
> These two functions are defined in .c file, but called just once
> (at least for now). So, the compiler will fold them into their
> callers even without the "inline" markers.
>
> However, this kind of optimization should not be done by hand.
> It is compiler's judge after all.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
> drivers/nvmem/core.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

This isn't really a bugfix, so should wait for 4.15-rc1.

thanks,

greg k-h