Re: [PATCH][V2] libata: make const arrays static, reduces object code size

From: Sergei Shtylyov
Date: Mon Sep 18 2017 - 12:54:45 EST


Hello!

On 09/18/2017 04:32 PM, Colin King wrote:

From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Don't populate const arrays on the stack, instead make them static.
Makes the object code smaller by over 260 bytes:

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/ata/libata-scsi.c | 10 +++++-----
fs/ocfs2/dlm/dlmrecovery.c | 1 -
2 files changed, 5 insertions(+), 6 deletions(-)
[...]
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index 74407c6dd592..31a61e8e0152 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm,
(mres->num_locks * sizeof(struct dlm_migratable_lock));
/* add an all-done flag if we reached the last lock */
- orig_flags = mres->flags;

What's that? :-/

BUG_ON(total_locks > mres_total_locks);
if (total_locks == mres_total_locks)
mres->flags |= DLM_MRES_ALL_DONE;

MBR, Sergei