Re: [RFC] iommu: arm-smmu: stall support
From: Will Deacon
Date: Mon Sep 18 2017 - 13:33:26 EST
On Mon, Sep 18, 2017 at 08:11:47AM -0400, Rob Clark wrote:
> IIRC Will or Robin mentioned wanting a token in earlier stall
> discussion.. although not being familiar with v3 I wasn't quite sure
> what the use was.
> At any rate, adding a token to fault handler callback and
> iommu_domain_resume() seems like something that could be added later,
> when it is needed.
> Anyways, I am interested to see what your proposal is.. although tend
> to be a bit sceptical about trying to abstract too much. (And if
> there should be something more abstract, maybe it should be at the
> dma-mapping layer instead?)
Whilst I'm also often sceptical about premature abstraction (which is why
I previously suggested just plugging into iommu_set_fault_handler and
managing any work queues yourself), in this case Jean-Philippe actually
has SVM up and running with multiple hardware platforms using stalls, so
I'm confident that if we have something that works for both of you, then
it's worth abstracting at this stage.
When we last had this discussion, you were the only person writing code
for this, but I think that things have moved on since then.
> I don't suppose you or someone working on this from ARM side will be
> at linaro connect in a couple weeks? Jordan and myself will be there,
> and it could be a good time to chat about this, and also per-process
> pagetables and gpu switching switching pagetables directly on v2 hw.
James Morse (CC'd) will be there from our group. He's not looked at this
at all, but it might be worth speaking to him anyway as this is often
better done face-to-face than over email.