Re: [PATCH 16/16] thunderbolt: Add support for networking over Thunderbolt cable
From: Andrew Lunn
Date: Mon Sep 18 2017 - 19:22:10 EST
On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote:
> From: Amir Levy <amir.jer.levy@xxxxxxxxx>
> ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet
> traffic over a Thunderbolt cable. The protocol consists of configuration
> phase where each side sends ThunderboltIP login packets (the protocol is
> determined by UUID in the XDomain packet header) over the configuration
> channel. Once both sides get positive acknowledgment to their login
> packet, they configure high-speed DMA path accordingly. This DMA path is
> then used to transmit and receive networking traffic.
> This patch creates a virtual ethernet interface the host software can
> use in the same way as any other networking interface. Once the
> interface is brought up successfully network packets get tunneled over
> the Thunderbolt cable to the remote host and back.
> The connection is terminated by sending a ThunderboltIP logout packet
> over the configuration channel. We do this when the network interface is
> brought down by user or the driver is unloaded.
> Signed-off-by: Amir Levy <amir.jer.levy@xxxxxxxxx>
> Signed-off-by: Michael Jamet <michael.jamet@xxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Reviewed-by: Yehezkel Bernat <yehezkel.bernat@xxxxxxxxx>
> Documentation/admin-guide/thunderbolt.rst | 24 +
> drivers/thunderbolt/Kconfig | 12 +
> drivers/thunderbolt/Makefile | 3 +
> drivers/thunderbolt/net.c | 1392 +++++++++++++++++++++++++++++
> 4 files changed, 1431 insertions(+)
> create mode 100644 drivers/thunderbolt/net.c
Could this be renamed to driver/net/thunderbolt.c?
At minimum, it needs a MAINTAINER entry pointing to netdev, so patches
get reviewed by netdev people. However, since the driver seems to be a
lot more netdev than thunderbolt, placing it in driver/net could be