Re: [PATCH 1/2] clocksource: stm32: rework driver to use only one timer
From: Daniel Lezcano
Date: Tue Sep 19 2017 - 11:54:46 EST
On 19/09/2017 09:59, Benjamin Gaignard wrote:
> 2017-09-18 23:30 GMT+02:00 Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>:
>> On 14/09/2017 09:56, Benjamin Gaignard wrote:
>>> Rework driver code to use only one timer for both clocksource
>>> and clockevent.
>>> This patch also forbids to use 16 bits timers because they are
>>> not enough accurate.
>>> Do some clean up in structures and functions names too.
>>> Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx>
>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
>> Hi Benjamin,
>> I have a few comments below. Can you when reposting split this patch
>> into smaller changes ?
> Not so easy because I change the way of how the hardware is used to be able
> to provide clocksource and clockevent on the same hardware block.
>> Also, can you consider using the timer-of API ?
> Is it just about using TIMER_OF_DECLARE ? or do you have something
> else in mind ?
It is something else, see commit dc11bae785.
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |