Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

From: BjÃrn Mork
Date: Tue Sep 19 2017 - 13:46:11 EST

Douglas Anderson <dianders@xxxxxxxxxxxx> writes:

> Every once in a while when my system is under a bit of stress I see
> some spammy messages show up in my logs that say:
> kevent X may have been dropped
> As far as I can tell these messages aren't terribly useful.

I agree, FWIW. These messages just confuse users for no purpose at all.

> + /* If work is already started this will mark it to run again when it
> + * finishes; if we already had work pending and it hadn't started
> + * yet then that's fine too.
> + */
> + schedule_work (&dev->kevent);
> + netdev_dbg(dev->net, "kevent %d scheduled\n", work);

Or maybe

if (schedule_work (&dev->kevent))
netdev_dbg(dev->net, "kevent %d scheduled\n", work);

? Not that I think it matters much.