Re: [PATCH 0/5] nvmem: some cleanups and sparse warning fixes
From: Masahiro Yamada
Date: Wed Sep 20 2017 - 06:03:17 EST
2017-09-11 22:00 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> Socionext is trying to add a new nvmem driver.
> Before adding a new one, I'd like to be sure about the preferred
> coding style in this subsystem, and build-up cleaner code base.
> Please pick up what you like. Please feel free to throw away
> what you do not like.
> 1/5, 2/5: convert kzalloc to stack because nvmem_config
> is small one-time use data.
> This is what we agreed in the discussion.
> 3/5, 4/5: fix sparse warning
> For mtk-efuse, qfprom, the base address is the only private data
> but, assigning (void __iomem *) to ->priv directly causes sparse
> 5/5: clean-up of owner settings - if the owner field matches
> nvmem->dev->driver->onwer, we need not set the onwer field
Does this series look OK?