Re: [PATCH] selinux: Use kmem_cache for hashtab_node

From: Paul Moore
Date: Wed Sep 20 2017 - 12:09:24 EST


On Thu, Sep 7, 2017 at 7:18 PM, Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Wed, Sep 6, 2017 at 5:50 AM, Kyeongdon Kim <kyeongdon.kim@xxxxxxx> wrote:
>> During random test as own device to check slub account,
>> we found some slack memory from hashtab_node(kmalloc-64).
>> By using kzalloc(), middle of test result like below:
>> allocated size 240768
>> request size 45144
>> slack size 195624
>> allocation count 3762
>>
>> So, we want to use kmem_cache_zalloc() and that
>> can reduce memory size 52byte(slack size/alloc count) per each struct.
>>
>> Signed-off-by: Kyeongdon Kim <kyeongdon.kim@xxxxxxx>
>> ---
>> security/selinux/ss/hashtab.c | 17 +++++++++++++++--
>> security/selinux/ss/hashtab.h | 4 ++++
>> security/selinux/ss/services.c | 4 ++++
>> 3 files changed, 23 insertions(+), 2 deletions(-)
>
> This seems reasonale, but I'm going to refrain from merging this until
> after the merge window closes.

I just merged this into selinux/next, thanks for your patience.

--
paul moore
www.paul-moore.com