Re: [PATCH 1/2] mux: add mux_control_get_optional() API
From: Stephen Boyd
Date: Wed Sep 20 2017 - 12:11:58 EST
Quoting Hans de Goede (2017-09-19 11:35:50)
> On 09/08/2017 05:54 PM, Peter Rosin wrote:
> > On 2017-09-08 17:45, Peter Rosin wrote:
> >> From: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
> >> Sometimes drivers only use muxes under certain scenarios. For
> >> example, the chipidea usb controller may be connected to a usb
> >> switch on some platforms, and connected directly to a usb port on
> >> others. The driver won't know one way or the other though, so add
> >> a mux_control_get_optional() API that allows the driver to
> >> differentiate errors getting the mux from there not being a mux
> >> for the driver to use at all.
> >> ---
> >> Documentation/driver-model/devres.txt | 1 +
> >> drivers/mux/core.c | 104 +++++++++++++++++++++++++++-------
> >> include/linux/mux/consumer.h | 4 ++
> >> 3 files changed, 89 insertions(+), 20 deletions(-)
> >> I haven't tested this patch, and hence I have not signed it and I also
> >> removed the sign-off from Stephen...
> > Huh, I definitely intended to mention that this patch is based on 
> > from Stephen, but that I've made changes according to the comments in
> > that thread (and more). And those changes are what made me remove the
> > sign-off from Stephen...
> AFAIK normally a Signed-off-by is kept if some (small-ish) changes
> are made. The S-o-b is mostly an indication that the author is
> ok with adding the code to the kernel under the GPL.
> Anyways, Stephen are you ok with re-adding your S-o-b to
> the version modified by Peter?
Please add my sign off
Signed-off-by: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
and I would expect Peter to have one as well with a maintainer tag
indicating what changed from my patch.