Re: [PATCH] init/version: include <linux/export.h> instead of <linux/module.h>

From: Paul Gortmaker
Date: Wed Sep 20 2017 - 16:55:57 EST


[[PATCH] init/version: include <linux/export.h> instead of <linux/module.h>] On 21/09/2017 (Thu 00:23) Masahiro Yamada wrote:

> init/version.c has nothing to do with module, so remove
> the <linux/modude.h>.
>
> Instead, include <linux/export.h> for EXPORT_SYMBOL_GPL.

I checked and there weren't any __init lurking in that file which is the
usual other required replacement (<linux/init.h>) so this should be
fine.

Paul.
--

>
> This cuts off a lot of unnecessary header parsing.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> init/version.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/version.c b/init/version.c
> index 5606341..bfb4e3f 100644
> --- a/init/version.c
> +++ b/init/version.c
> @@ -7,7 +7,7 @@
> */
>
> #include <generated/compile.h>
> -#include <linux/module.h>
> +#include <linux/export.h>
> #include <linux/uts.h>
> #include <linux/utsname.h>
> #include <generated/utsrelease.h>
> --
> 2.7.4
>