Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob

From: David Miller
Date: Wed Sep 20 2017 - 17:25:15 EST


From: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
Date: Tue, 19 Sep 2017 17:38:15 +0800

> @@ -128,6 +130,8 @@ struct netns_ipv4 {
> struct inet_timewait_death_row tcp_death_row;
> int sysctl_max_syn_backlog;
> int sysctl_tcp_fastopen;
> + struct tcp_fastopen_context __rcu *tcp_fastopen_ctx;
> + spinlock_t tcp_fastopen_ctx_lock;
>
> #ifdef CONFIG_NET_L3_MASTER_DEV
> int sysctl_udp_l3mdev_accept;

Where are you releasing this context during netns teardown?
I think this is a leak.