Re: [PATCH] selftests/seccomp: Support glibc 2.26 siginfo_t.h
From: Kees Cook
Date: Wed Sep 20 2017 - 18:02:37 EST
On Thu, Sep 7, 2017 at 8:36 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, Sep 7, 2017 at 8:19 PM, Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote:
>> On Thu, Sep 07, 2017 at 04:32:46PM -0700, Kees Cook wrote:
>>> The 2.26 release of glibc changed how siginfo_t is defined, and the earlier
>>> work-around to using the kernel definition are no longer needed. The old
>>> way needs to stay around for a while, though.
>>> Reported-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
>>> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>>> Cc: Will Drewry <wad@xxxxxxxxxxxx>
>>> Cc: Shuah Khan <shuah@xxxxxxxxxx>
>>> Cc: linux-kselftest@xxxxxxxxxxxxxxx
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>> Seth, can you double check this to confirm it works for you too? This builds
>>> and tests correctly for me on both Ubuntu 17.10 (-proposed) with glibc 2.26
>>> and with earlier distros with 2.24, etc.
>> It builds and tests correctly for me too, with both glibc 2.26 and 2.24.
>> Tested-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx>
> Awesome, thanks!
> Shuah, is it possible to land this for v4.14? If it has to wait,
> that's probably okay, as I've marked it for -stable, so it'll get
> where it needs to be eventually. :)
Friendly ping, Shuah, are you able to take this?