Re: [PATCH net] net/ncsi: Don't assume last available channel exists

From: David Miller
Date: Wed Sep 20 2017 - 19:05:30 EST

From: Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>
Date: Wed, 20 Sep 2017 14:12:51 +1000

> When handling new VLAN tags in NCSI we check the maximum allowed number
> of filters on the last active ("hot") channel. However if the 'add'
> callback is called before NCSI has configured a channel, this causes a
> NULL dereference.
> Check that we actually have a hot channel, and warn if it is missing.
> Signed-off-by: Samuel Mendoza-Jonas <sam@xxxxxxxxxxxxxxxx>

Well, a few things.

We should not allow this driver method to be invoked in the first
place if the device is not in a state where the operation is legal

Second of all, if !ndp is true, you should not return 0 to indicate

But more fundamentally, we should block this method from being
callable unless the device is in the proper state and can complete the

Seriously, these checks should be completely unnecessary if those
issues are handled properly.