Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in

From: Dan Carpenter
Date: Thu Sep 21 2017 - 03:16:00 EST


On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
> u32 oldval_0, x, tx0_a, reg;
> s32 y, tx0_c;
>
> - if (final_candidate == 0xFF) {
> + if (final_candidate == 0xFF)
> return;
> - } else if (iqkok) {
> + else if (iqkok) {

No. These ones stay. Your change would introduce a new checkpatch.pl
warning if you ran it against the patched file. The rule here is that
if one side of the if else has curly braces then both sides get them.

regards,
dan carpenter