Re: [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable

From: Steven Rostedt
Date: Thu Sep 21 2017 - 23:15:40 EST



Peter,

Do you have any qualms with this patch set?

-- Steve


On Thu, 21 Sep 2017 18:50:22 -0700
Joel Fernandes <joelaf@xxxxxxxxxx> wrote:

> These patches add trace events support for preempt and irq disable/enable
> events.
>
> Changes since v5:
> - Use trace_*_rcuidle variants (thanks Steve!)
>
> Here's an example of how Android's systrace will be using it to show critical
> sections as a gantt chart: http://imgur.com/download/TZplEVp
>
> Links to earlier series:
> v5: https://lkml.org/lkml/2017/9/12/507
> v4: https://lkml.org/lkml/2017/9/6/724
> v3: https://lkml.org/lkml/2017/9/3/15
>
> Joel Fernandes (2):
> tracing: Prepare to add preempt and irq trace events
> tracing: Add support for preempt and irq enable/disable events
>
> include/linux/ftrace.h | 3 +-
> include/linux/irqflags.h | 4 +-
> include/trace/events/preemptirq.h | 66 ++++++++++++++
> kernel/trace/Kconfig | 9 ++
> kernel/trace/Makefile | 1 +
> kernel/trace/trace_irqsoff.c | 176 +++++++++++++++++++++++++++++++-------
> 6 files changed, 226 insertions(+), 33 deletions(-)
> create mode 100644 include/trace/events/preemptirq.h
>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Peter Zilstra <peterz@xxxxxxxxxxxxx>