[PATCH v2] staging: greybus: light: Release memory obtained by kasprintf

From: Arvind Yadav
Date: Fri Sep 22 2017 - 01:20:58 EST


- Free memory region, if gb_lights_channel_config is not successful.
- No need to add check for gb_lights_channel_flash_config().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
---
changes in v2:
- Subject line changed.
- add kfree in __gb_lights_led_unregister().
- No need to check return value of gb_lights_channel_flash_config().

drivers/staging/greybus/light.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 3f4148c..bc1f8d2 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -926,6 +926,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel)

led_classdev_unregister(cdev);
channel->led = NULL;
+ kfree(cdev->name);
+ cdev->name = NULL;
}

static void gb_lights_channel_unregister(struct gb_channel *channel)
@@ -998,11 +1000,8 @@ static int gb_lights_channel_config(struct gb_light *light,

light->has_flash = true;

- ret = gb_lights_channel_flash_config(channel);
- if (ret < 0)
- return ret;
+ return gb_lights_channel_flash_config(channel);

- return ret;
}

static int gb_lights_light_config(struct gb_lights *glights, u8 id)
--
1.9.1