Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

From: Johannes Berg
Date: Fri Sep 22 2017 - 02:00:42 EST


On Thu, 2017-09-21 at 23:56 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate const array ac_to_fifo on the stack in an inlined
> function, instead make it static.ÂÂMakes the object code smaller
> by over 800 bytes:
>
> ÂÂÂtext ÂÂÂdata ÂÂÂÂbss ÂÂÂÂdec ÂÂÂÂhex
> filename
> Â159029 ÂÂ33154 ÂÂÂ1216 Â193399 ÂÂ2f377
> 4965-mac.o
>
> ÂÂÂtext ÂÂÂdata ÂÂÂÂbss ÂÂÂÂdec ÂÂÂÂhex
> filename
> Â158122 ÂÂ33250 ÂÂÂ1216 Â192588 ÂÂ2f04c
> 4965-mac.o
>
> (gcc version 7.2.0 x86_64)

I'm curious - how did you find this?

johannes