Re: [PATCH 02/10] drivers:tty: imx: use setup_timer() helper.

From: Uwe Kleine-König
Date: Fri Sep 22 2017 - 05:05:39 EST


Hello,

$Subject ~= s/:/: /

On Fri, Sep 22, 2017 at 01:56:44PM +0530, Allen Pais wrote:
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx>
> ---
> drivers/tty/serial/imx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index dfeff39..64f57c6 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2115,9 +2115,7 @@ static int serial_imx_probe(struct platform_device *pdev)
> sport->port.rs485.flags =
> SER_RS485_RTS_ON_SEND | SER_RS485_RX_DURING_TX;
> sport->port.flags = UPF_BOOT_AUTOCONF;
> - init_timer(&sport->timer);
> - sport->timer.function = imx_timeout;
> - sport->timer.data = (unsigned long)sport;
> + setup_timer(&sport->timer, imx_timeout, (unsigned long)sport);

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |