Re: [RFC][PATCH] sched: Cleanup task->state printing
From: Peter Zijlstra
Date: Fri Sep 22 2017 - 11:56:57 EST
On Fri, Sep 22, 2017 at 10:12:45AM -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 13:54:30 +0200
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > I should probably split this thing into a bunch of patches :/
> Yes please. Convert form dec to hex in one patch and one patch only.
Yeah, was already on it, did more cleanups too.
> Because I'm not sure if you meant to change numbers or not.
> > /* Used in tsk->state again: */
> > -#define TASK_DEAD 64
> > -#define TASK_WAKEKILL 128
> > -#define TASK_WAKING 256
> > -#define TASK_PARKED 512
> > -#define TASK_NOLOAD 1024
> > -#define TASK_NEW 2048
> > -#define TASK_STATE_MAX 4096
> > +#define TASK_PARKED 0x0040
> > +#define TASK_REPORT_MAX 0x0080
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> > +/* Not in TASK_REPORT: */
> > +#define TASK_DEAD 0x0080
> TASK_DEAD went from 64 to 128 (0x40 to 0x80)
> As well as all the defines below that. Was this on purpose?
Yes, was on purpose. I moved TASK_PARKED up, such that I could include
it in the TASK_REPORT mask and keep that contiguous.