Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

From: Jesse Brandeburg
Date: Fri Sep 22 2017 - 12:44:42 EST


On Fri, 22 Sep 2017 15:11:38 +0100
Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate const array patterns on the stack, instead make it
> static. Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 1953 496 0 2449 991 i40e_diag.o
>
> After:
> text data bss dec hex filename
> 1798 584 0 2382 94e i40e_diag.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Looks good, thanks Colin!

Acked-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>