Re: [PATCH] Asus WMI : Add lightbar led support
From: Darren Hart
Date: Fri Sep 22 2017 - 20:18:37 EST
On Thu, Sep 21, 2017 at 01:20:01PM +0200, Maxime Bellengé wrote:
> Some asus laptops (ROG series for example) are provided with a lightbar behind the monitor.
> This patch make posible to switch it on and off. This lightbar works exactly as any other led.
The patch looks good from a functional implementation perspective.
There are 3 mechanical and style errors the checkpatch script catches. Please
update the patch and resubmit:
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
Some asus laptops (ROG series for example) are provided with a lightbar behind the monitor.
WARNING: 'posible' may be misspelled - perhaps 'possible'?
This patch make posible to switch it on and off. This lightbar works exactly as any other led.
WARNING: please, no space before tabs
#101: FILE: drivers/platform/x86/asus-wmi.c:122:
+#define ASUS_WMI_DEVID_LIGHTBAR ^I0x00050025$
total: 0 errors, 3 warnings, 103 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/home/dvhart/incoming/PATCH_Asus_WMI_Add_lightbar_led_support.mbox has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
VMware Open Source Technology Center