Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone

From: Jonathan Cameron
Date: Sun Sep 24 2017 - 10:23:15 EST


On Mon, 18 Sep 2017 10:27:03 +0200
Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:

> Hi Jonathan,
>
> On Sat, Sep 16, 2017 at 03:17:34PM -0700, Jonathan Cameron wrote:
> > On Sat, 16 Sep 2017 12:05:49 +0200
> > Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Hi Icenowy,
> > >
> > > On 14/09/2017 16:52, Icenowy Zheng wrote:
> > > > Because of the restriction of the OF thermal framework, the thermal
> > > > sensor will fail to probe if the thermal zone doesn't exist.
> > > >
> > >
> > > Oh no, that's not good.
> > >
> > > We discussed about it on IRC and I even proposed a patch for it, telling
> > > you I would post it on the mailing list soon after. Of course, I forgot
> > > and you definitely should have yelled at me for not doing it :)
> > >
> > > I won't be able to test the patch soon. I can send it to you so that you
> > > can test it and integrate it in your patch series so it won't block you.
> > > Otherwise, we'll have to wait for a week or two for me to test it.
> > >
> > > Thanks and sorry for forgetting to post the patch you need,
> > > Quentin
> >
> > Other this outstanding issue I'm happy with the series, so hopefully
> > with Quentin's patch added we should be good to merge this one.
>
> We will at least need a v5.
>
> Maxime
>
Sure - I can see other issues are coming out of the woodwork!

Thanks,

Jonathan