Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition

From: Guenter Roeck
Date: Mon Sep 25 2017 - 10:58:28 EST


On Mon, Sep 25, 2017 at 01:54:02PM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
>
> Source code is
>
> (!upper || (upper && data->has_status_word)) &&
>
Please feel free to submit a patch.

Thanks,
Guenter