Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

From: David Miller
Date: Tue Sep 26 2017 - 23:03:44 EST

Next message: Zhenzhong Duan: "[PATCH] Call xen_cleanhighmap() with 4MB aligned for page tables mapping"
Previous message: Wei Hu (Xavier): "Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver"
In reply to: Tim Hansen: "[PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974."
Next in thread: Tim Hansen: "Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Tim Hansen <devtimhansen@xxxxxxxxx>
Date: Tue, 26 Sep 2017 20:54:05 -0400

> Signed-off-by: Tim Hansen <devtimhansen@xxxxxxxxx>

This is a poor patch submission on many levels.

But the main problem, is that there is no use of
sk_for_each_entry_offset_rcu() in any of my networking kernel trees.

Referencing code by line number never works, you have to mention
what version of the kernel, what tree, and where in what fucntion
the problem is occurring.

Secondly, sk_for_each_entry_offset_rcu() is not meant to be used
in _raw() contexts. This is why it's not called
sk_for_each_entry_offset_rcu_raw().

The sparse warning is probably legitimate, and points to a bug.

But nobody can tell where becuase you haven't told us what tree
and where this happens.