Re: [PATCH v2] tun: bail out from tun_get_user() if the skb is empty

From: Eric Dumazet
Date: Wed Sep 27 2017 - 09:26:16 EST


On Wed, Sep 27, 2017 at 5:58 AM, Alexander Potapenko <glider@xxxxxxxxxx> wrote:
> On Wed, Sep 27, 2017 at 2:45 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
>> On Wed, 2017-09-27 at 05:42 -0700, Eric Dumazet wrote:
>>
>>> Or something cleaner to avoid copy/paste and focus on proper
>>> skb->data[0] access and meaning.
> By the way I'm wondering if this is the only place where skb->data is
> being accessed.
> Isn't eth_type_trans() under IFF_TAP also touching it? Then we need to
> check the size earlier.

It is already checked.