Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

From: David Miller
Date: Sat Sep 30 2017 - 23:08:35 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 29 Sep 2017 15:01:16 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The assignment of -EINVAL to variable ret is redundant as it
> is being overwritten on the following error exit paths or
> to the return value from the following call to basic_set_parms.
> Fix this up by removing it. Cleans up clang warning message:
>
> net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.