Re: [PATCH V2] firmware: tegra: add BPMP debugfs support

[Timo Alho]

Jon, thanks for reviewing

On 03.10.2017 13:55, Jonathan Hunter wrote:
> > +static int create_debugfs_mirror(struct tegra_bpmp *bpmp, void *buf,
> > +				 size_t bufsize, struct dentry *root)
> > +{
> > +	struct seqbuf seqbuf;
> > +	int err;
> > +
> > +	bpmp->debugfs_mirror = debugfs_create_dir("debug", root);
> > +	if (!bpmp->debugfs_mirror)
> > +		return -ENOMEM;
>
> Is this extra level needed? Do you plan to have other sub-directories
> under the main bpmp directory?

Yes, the downstream driver has few files under main directory (e.g. 
'ping' to check that firmware is alive, or 'tag' to read the firmware 
version).

BR,
Timo