Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing

[Matthew Wilcox]

On Tue, Oct 03, 2017 at 07:41:11AM -0700, Eric Dumazet wrote:
> On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik <mguzik@xxxxxxxxxx> wrote:
> > Explicit locking in the fallback case provides a safe state of the
> > table. Getting rid of blocking semantics makes __fd_install usable
> > again in non-sleepable contexts, which easies backporting efforts.
> >
> > There is a side effect of slightly nicer assembly for the common case
> > as might_sleep can now be removed.
> >
> > Signed-off-by: Mateusz Guzik <mguzik@xxxxxxxxxx>
> > ---
> >  Documentation/filesystems/porting |  4 ----
> >  fs/file.c                         | 11 +++++++----
> >  2 files changed, 7 insertions(+), 8 deletions(-)
> 
> Nice change !
> 
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Hey Eric,

Any chance you could review the patches from Sandhya that make this entire
codepath obsolete?

https://lkml.org/lkml/2017/4/29/20