Re: [PATCH 1/2] writeback: eliminate work item allocation in bd_start_writeback()

From: Jens Axboe
Date: Wed Oct 04 2017 - 10:42:22 EST


On 10/04/2017 01:26 AM, Jan Kara wrote:
>> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
>> index 420de5c7c7f9..f0f1df29d6b8 100644
>> --- a/include/linux/backing-dev-defs.h
>> +++ b/include/linux/backing-dev-defs.h
>> @@ -116,6 +116,7 @@ struct bdi_writeback {
>>
>> struct fprop_local_percpu completions;
>> int dirty_exceeded;
>> + int start_all_reason;
>
> This should be 'enum wb_reason' instead of 'int'.

Yes good point, I'll move the enum and change 'start_all_reason' to be
of type enum wb_reason.

Thanks for the review!

--
Jens Axboe