Re: [GIT PULL 0/1] perf callchain symbol resolving fix

From: Ingo Molnar
Date: Thu Oct 05 2017 - 14:08:03 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 1addcd55bc54d669000221b41e379458ff3e6747:
>
> Merge tag 'perf-urgent-for-mingo-4.14-20170928' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2017-09-29 19:31:46 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171005
>
> for you to fetch changes up to c1fbc0cf81f1c464f5fda322c1104d4bb1da6711:
>
> perf callchain: Compare dsos (as well) for CCKEY_FUNCTION (2017-10-05 10:52:54 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fix:
>
> . Two functions from different binaries can have same start address. Thus,
> comparing only start address in match_chain() leads to inconsistent
> callchains. Fix this by adding a check for dsos as well (Ravi Bangoria)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> ----------------------------------------------------------------
> Ravi Bangoria (1):
> perf callchain: Compare dsos (as well) for CCKEY_FUNCTION
>
> tools/perf/util/callchain.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

Pulled, thanks a lot Arnaldo!

Ingo