Re: [PATCH workqueue/for-4.14-fixes] workqueue: replace pool->manager_arb mutex with a flag

From: Tejun Heo
Date: Mon Oct 09 2017 - 11:34:06 EST


Hello, Lai.

On Mon, Oct 09, 2017 at 11:14:20PM +0800, Lai Jiangshan wrote:
> > wait_event_lock_irq() drops the lock if the condition is not met
> > before going to sleep (otherwise it wouldn't be able to sleep).
>
> I think just using get_pwq()/put_pwq() in manage_workers()
> as the following said is simpler than using wait_event_lock_irq()

Hmm... let's stay with the current implementation for the fix as it's
more straight-forward. We can simplify it later if that'd be
worthwhile.

Thanks.

--
tejun