Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

[Masahiro Yamada]

2017-10-06 5:58 GMT+09:00 Doug Anderson <dianders@xxxxxxxxxxxx>:
> Hi,
>
> On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> As far as I tested, I always see only one space after ":=" in v2.
>>
>> I did not consider this deeply,
>> but something is working nicely behind the scene.
>
> Try adding this to the end of the main Makefile:
>
> +$(info LDFLAGS_BUILD_ID = $(LDFLAGS_BUILD_ID))
> +$(info KBUILD_ARFLAGS = $(KBUILD_ARFLAGS))
> +$(info KBUILD_CFLAGS = $(KBUILD_CFLAGS))
> +$(info KBUILD_AFLAGS = $(KBUILD_AFLAGS))
> +$(info KBUILD_CPPFLAGS = $(KBUILD_CPPFLAGS))
> +$(info REALMODE_CFLAGS = $(REALMODE_CFLAGS))
> +
>  endif  # skip-makefile
>
> Record what you see.  Then apply my patches and run your build again
> (actually, run it twice and look at the 2nd time, just to be sure).  I
> think you'll see slightly different spacing in the flags for the two
> runs.  I don't think this is terribly important, though.
>

Yes.  I see slight difference
in the resulted KBUILD_CFLAGS etc.

What I meant is:

In v2, I always see only one space after the assignment operator ":="
in .cache.mk
even without $(strip )


$(call cc-option,-fno-PIE)
$(call cc-option, -fno-PIE)
$(call cc-option,                   -fno-PIE)


All of the three gave me the same result.




-- 
Best Regards
Masahiro Yamada