[PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

From: Jonathan Liu
Date: Mon Oct 09 2017 - 22:44:54 EST


This fixes a kernel oops when unloading the driver due to usb_put_phy
being called after usb_phy_generic_unregister when the device is
detached. Calling usb_phy_generic_unregister causes x->dev->driver to
be NULL in usb_put_phy and results in a NULL pointer dereference.

Cc: stable@xxxxxxxxxxxxxxx # v4.3+
Signed-off-by: Jonathan Liu <net147@xxxxxxxxx>
---
Changes for v2:
- Use devm_usb_put_phy instead of usb_put_phy

drivers/usb/musb/sunxi.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index c9a09b5bb6e5..dc353e24d53c 100644
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c
@@ -297,6 +297,8 @@ static int sunxi_musb_exit(struct musb *musb)
if (test_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags))
sunxi_sram_release(musb->controller->parent);

+ devm_usb_put_phy(glue->dev, glue->xceiv);
+
return 0;
}

--
2.14.2