Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit

From: Ulf Hansson
Date: Tue Oct 10 2017 - 03:19:21 EST


On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@xxxxxxxxxxxx> wrote:
> On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote:
>>
>> On 10/09/2017 01:35 PM, Chaotian Jing wrote:
>> > the driver has updated to have an explicit compatible, so update
>> > binding file according to the driver change.
>> >
>> > Signed-off-by: Chaotian Jing <chaotian.jing@xxxxxxxxxxxx>
>> > ---
>> > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>> > index 3e0a97c..2bb585b 100644
>> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>> > @@ -8,8 +8,8 @@ and the properties used by the msdc driver.
>> >
>> > Required properties:
>> > - compatible: value should be either of the following.
>> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
>> > - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173
>> > + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
>> > + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
>>
>> You can merge this with patch 1.
>
> OK, will merge it in next patch.

No, please don't!

I would like DT documentation changes to be posted in separate
patches. Moreover, those should be before driver changes, when you
order the changes in your series.

In this way, the bindings can be reviewed and acked separately, which
makes it more convenient.

Kind regards
Uffe