Re: [PATCH] arch/x86: remove redundant null checks before kmem_cache_destroy

From: Paolo Bonzini
Date: Tue Oct 10 2017 - 04:40:39 EST


On 08/10/2017 05:15, Tim Hansen wrote:
> Remove redundant null checks before calling kmem_cache_destroy.
>
> Found with make coccicheck M=arch/x86/kvm on linux-next tag
> next-20170929.
>
> Signed-off-by: Tim Hansen <devtimhansen@xxxxxxxxx>
> ---
> arch/x86/kvm/mmu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index eca30c1eb1d9..a6c7177326c5 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -5463,10 +5463,8 @@ static struct shrinker mmu_shrinker = {
>
> static void mmu_destroy_caches(void)
> {
> - if (pte_list_desc_cache)
> - kmem_cache_destroy(pte_list_desc_cache);
> - if (mmu_page_header_cache)
> - kmem_cache_destroy(mmu_page_header_cache);
> + kmem_cache_destroy(pte_list_desc_cache);
> + kmem_cache_destroy(mmu_page_header_cache);
> }
>
> int kvm_mmu_module_init(void)
>

Queued, thanks.

Paolo