Re: [PATCH v4 0/6] fs/dcache: Limit # of negative dentries

From: Andrew Morton
Date: Tue Oct 10 2017 - 18:54:47 EST


On Mon, 18 Sep 2017 14:20:28 -0400 Waiman Long <longman@xxxxxxxxxx> wrote:

> A rogue application can potentially create a large number of negative
> dentries in the system consuming most of the memory available even if
> memory controller is enabled to limit memory usage. This can impact
> performance of other applications running on the system.

It does seem that under these circumstances it is pretty silly of us to
reclaim useful things in order to instantiate zillions of -ve dentries.

Dentries are subject to kmemcg handling. Does this not help avoid
"impacting performance of other applications"?

> We have customers seeing soft lockup and unresponsive system when
> tearing down a container because of the large number of negative
> dentries accumulated during its up time that had to be cleaned up at
> exit time when the container's filesystem was unmounted. So we need
> to do something about it.

It's a somewhat separate issue, but maybe we're missing a cond_resched
somewhere? Seeing such a softlockup's output would help.