Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

From: Kalle Valo
Date: Wed Oct 11 2017 - 04:42:02 EST


Jes Sorensen <jes.sorensen@xxxxxxxxx> writes:

> On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> While this isn't harmful, to me this looks like pointless patch churn
> for zero gain and it's just ugly.

In general I find it useful to mark fall through cases. And it's just a
comment with two words, so they cannot hurt your eyes that much.

--
Kalle Valo