Re: [PATCH] hdlc: Convert timers to use timer_setup()

From: David Miller
Date: Wed Oct 11 2017 - 18:19:18 EST


From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Tue, 10 Oct 2017 15:08:33 -0700

> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. This adds a pointer back to the
> net_device, and drops needless open-coded resetting of the .function and
> .data fields.
>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: Krzysztof Halasa <khc@xxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
> This requires commit 686fef928bba ("timer: Prepare to change timer
> callback argument type") in v4.14-rc3, but should be otherwise
> stand-alone.

This doesn't apply cleanly to net-next, please respin.