Re: [PATCH] IB/hfil: Delete unused bypass flags

[Dennis Dalessandro]

On 10/11/2017 5:35 PM, Don Hiatt wrote:
> On 10/11/2017 1:56 PM, Christos Gkekas wrote:
> > Clean up unused bypass variables in verbs.
> >
> > Signed-off-by: Christos Gkekas <chris.gekas@xxxxxxxxx>
> > ---
> > Â drivers/infiniband/hw/hfi1/verbs.c | 4 ----
> > Â 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/verbs.c 
> > b/drivers/infiniband/hw/hfi1/verbs.c
> > index e232f3c..62c3f4e 100644
> > --- a/drivers/infiniband/hw/hfi1/verbs.c
> > +++ b/drivers/infiniband/hw/hfi1/verbs.c
> > @@ -891,14 +891,12 @@ int hfi1_verbs_send_dma(struct rvt_qp *qp, 
> > struct hfi1_pkt_state *ps,
> > ÂÂÂÂÂ u8 sc5 = priv->s_sc;
> > ÂÂÂÂÂ int ret;
> > ÂÂÂÂÂ u32 dwords;
> > -ÂÂÂ bool bypass = false;
> > ÂÂÂÂÂ if (ps->s_txreq->phdr.hdr.hdr_type) {
> > ÂÂÂÂÂÂÂÂÂ u8 extra_bytes = hfi1_get_16b_padding((hdrwords << 2), len);
> > ÂÂÂÂÂÂÂÂÂ dwords = (len + extra_bytes + (SIZE_OF_CRC << 2) +
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ SIZE_OF_LT) >> 2;
> > -ÂÂÂÂÂÂÂ bypass = true;
> > ÂÂÂÂÂ } else {
> > ÂÂÂÂÂÂÂÂÂ dwords = (len + 3) >> 2;
> > ÂÂÂÂÂ }
> > @@ -1034,7 +1032,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, 
> > struct hfi1_pkt_state *ps,
> > ÂÂÂÂÂ int ret = 0;
> > ÂÂÂÂÂ pio_release_cb cb = NULL;
> > ÂÂÂÂÂ u32 lrh0_16b;
> > -ÂÂÂ bool bypass = false;
> > ÂÂÂÂÂ u8 extra_bytes = 0;
> > ÂÂÂÂÂ if (ps->s_txreq->phdr.hdr.hdr_type) {
> > @@ -1044,7 +1041,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, 
> > struct hfi1_pkt_state *ps,
> > ÂÂÂÂÂÂÂÂÂ dwords = (len + extra_bytes) >> 2;
> > ÂÂÂÂÂÂÂÂÂ hdr = (u32 *)&ps->s_txreq->phdr.hdr.opah;
> > ÂÂÂÂÂÂÂÂÂ lrh0_16b = ps->s_txreq->phdr.hdr.opah.lrh[0];
> > -ÂÂÂÂÂÂÂ bypass = true;
> > ÂÂÂÂÂ } else {
> > ÂÂÂÂÂÂÂÂÂ dwords = (len + 3) >> 2;
> > ÂÂÂÂÂÂÂÂÂ hdr = (u32 *)&ps->s_txreq->phdr.hdr.ibh;
> Thanks! Those were useful at one time. ;-)
>
> Reviewed-by: Don Hiatt <don.hiatt@xxxxxxxxx>

Thanks, but this is already handled by a patch submitted by Bart. See:

https://marc.info/?l=linux-rdma&m=150774420313310&w=2

His patch catches a few other variables in those same functions.

-Denny