Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size

From: Colin Ian King
Date: Thu Oct 12 2017 - 12:17:58 EST


On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
>
> [ added dri-devel ML to cc: ]
>
> On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Don't populate the read-only const array post_divs on the stack,
>> nstead make it static. Makes the object code smaller by 90 bytes:
>>
>> Before:
>> text data bss dec hex filename
>> 40231 8584 896 49711 c22f radeon_base.o
>>
>> After:
>> text data bss dec hex filename
>> 39914 8744 960 49618 c1d2 radeon_base.o
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Are these results obtained using the same compiler as the other patches
> (gcc version 7.2.0, x86_64)?

Yes, I forgot to annotate it.

Colin
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>