Re: [PATCH] tracing: Remove unused clock events

[Steven Rostedt]

On Fri, 13 Oct 2017 09:20:44 +0200
Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> wrote:

> Hi Steven,
> 
> On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > [ Resending again, including linux-pm@xxxxxxxxxxxxxxx this time ]
> >
> > From: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> >
> > Commit 74704ac6 ("tracing, perf: Add more power related events") added
> > new events, among them were trace_clock_enable, trace_clock_disable and
> > trace_clock_set_rate. In the last 7 years, nothing has used them. As
> > they take up space, and nobody cares about these events, remove them.  
> 
> Ok if it is not used. Can others confirm?
> 
> AFAIK this has been used internally.

If it has been used internally, then the events should be defined
internally. The trace event hooks are not there, there's no reason to
define events were hooks are not present. There's no advantage for
keeping them in the kernel proper.

-- Steve